Monday, 05 April 2021 17:03

ABAP Code Review Guideline is out

Written by Christoph Pohl
Rate this item
(0 votes)
“© 2020. SAP SE or an SAP affiliate company. All rights reserved.” “Used with permission of SAP SE”

A new guide on ABAP Code Reviews was added to the SAP Code Style Guides repository, which we want to briefly highlight in this blog post.

Change-based peer code reviews increase code quality by finding defects earlier and preventing them from polluting the main code line. They also enable continuous integration by registering automated checks as reviewers. These modern capabilities have been on the wish list of ABAP developers for some time.

Lars Hvam and I have surveyed current possibilities of applying git-based review platforms to ABAP code and give recommendations for authors and reviewers. We came up with a guideline and contributed it to the SAP Code Style Guides, and open source, grassroots project driven by the SAP community. You may know this project, for instance, from Klaus Haeuptle‘s recent blog post on Clean ABAP.

The latest released version contains an easily consumable PDF but you can also read it online.

The guide discusses how to apply well-known code review flows as known from other programming languages also to ABAP.


We start with previous work like the following:

Then we suggest a number of code review best practices comparable to Google’s Engineering Practices documentation, before we survey existing tools like Git, GitHub, CTS, abapGit and gCTS, ATC and abapLint, and their extension points.

We finally sketch different collaboration scenarios, in which git-based code reviews can be set up for ABAP development projects and give examples for those, using abapGit and gCTS respectively.

As always with open-source projects, contributions are welcome. Please do not hesitate to raise

Continue reading here
Read 58 times

Leave a comment

Make sure you enter all the required information, indicated by an asterisk (*). HTML code is not allowed.